Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Markup import; it is now imported from markupsafe #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

italomaia
Copy link
Contributor

Importing Markup from jinja2 doesn't work anymore. This fixes the issue. Also took the liberty of sorting imports.

@aareman
Copy link

aareman commented Mar 8, 2023

My team has a small flask application that depends on this library. @stewartpark is there any likelyhood of this PR being merged? (last commit on the repo was in 2018, so it looks like it's not being actively maintained.)

I appreciate the hard work you put in to making this very useful package.

@corlukantonio
Copy link

corlukantonio commented Mar 21, 2023

I also had one of my demo apps using this package running perfectly fine on Heroku, but since Heroku started requiring a newer stack (Heroku-22), the version of Python (3.7) I was using for the app became deprecated. I then switched to Python version 3.9 and kept getting this error when trying to run the app. Not sure if it was because of the Python version, but either way, I hope this gets seen by the author (@stewartpark) and merged.

@willfinnigan
Copy link

willfinnigan commented Dec 19, 2023

JSGlue is a great flask add-on - its a shame to not be able to use it anymore. Would be fantastic to have this pull request approved @stewartpark 😁

@aareman
Copy link

aareman commented Dec 19, 2023

@willfinnigan @corlukantonio you can always fork the repo with the pr and install that commit hash instead. That's what we ended up doing.

You can use my companies fork if you like https://github.com/Centers-Health/Flask-JSGlue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants